Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Playwright for E2E tests #3695

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Use Playwright for E2E tests #3695

merged 3 commits into from
Nov 15, 2022

Conversation

luin
Copy link
Member

@luin luin commented Nov 14, 2022 •
edited
Loading

This PR uses Playwright instead of puppeteer scripts. Pros:

  1. Easier to run locally or on GitHub Actions.
  2. Easier to organize tests and add more tests.
  3. Support Firefox, Safari, and Edge as well.

This PR doesn't reorganize the existing puppeteer scripts. We can do this in the following PRs together when we are going to add more E2E tests.

@luin luin force-pushed the zh-playwright branch 5 times, most recently from 6325ca5 to f6eef42 Compare November 14, 2022 14:02
@luin luin marked this pull request as ready for review November 14, 2022 16:43
@jhchen jhchen self-requested a review November 15, 2022 02:08
@jhchen jhchen merged commit 773a553 into develop Nov 15, 2022
@jhchen jhchen deleted the zh-playwright branch November 15, 2022 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhchen jhchen jhchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luin @jhchen