Migrate remaining files to TypeScript #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luin
force-pushed
the
zh-ts-3
branch
6 times, most recently
from
c10c292 to
b6f3864
Compare
luin
force-pushed
the
zh-ts-3
branch
6 times, most recently
from
78f5e99 to
0fbc62a
Compare
luin
force-pushed
the
zh-ts-3
branch
2 times, most recently
from
af028d1 to
cfc0ccb
Compare
luin
commented
Aug 18, 2022
| @@ -13,6 +13,9 @@ import Clipboard from './modules/clipboard'; | |||
| import History from './modules/history'; | |||
| import Keyboard from './modules/keyboard'; | |||
| import Uploader from './modules/uploader'; | |||
| import Delta, { Op, OpIterator, AttributeMap } from 'quill-delta'; | |||
|
|
|||
| export { Delta, Op, OpIterator, AttributeMap }; | |||
There was a problem hiding this comment.
Export quill-delta so users don't need to install quill-delta on their side. This is useful to prevent multiple versions of quill-delta coexist in a project and Delta.registerEmbed() being called on a wrong Delta instance.
An alternative is to get Delta from Quill.import('delta') but due to a TypeScript limit, users have to use typeof Delta instead of Delta when referring the type.
luin
commented
Aug 18, 2022
| "lint": "npm run lint:eslint && npm run lint:tsc", | ||
| "lint:eslint": "eslint .", | ||
| "lint:tsc": "tsc --noEmit --skipLibCheck", | ||
| "prepare": "npm run build", |
There was a problem hiding this comment.
When Quill is installed as a git dependency, the prepare script will be called by npm to build js files. It won't be called when it's installed as a normal npm package where files have already been built before publishing.
luin
commented
Aug 18, 2022
luin
force-pushed
the
zh-ts-3
branch
3 times, most recently
from
689625f to
14d92da
Compare
jhchen
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test:
Run
npm pack, make sure the bundle only contains necessary files.