Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar: add aria-pressed to toolbar buttons #3615

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

cmrd-senya
Copy link
Contributor

@cmrd-senya cmrd-senya commented Jul 27, 2022

This adds aria-pressed attributes to Toolbar buttons. The attribute value set consistently with ql-active presence or absence.

Ref #2038

@cmrd-senya
Copy link
Contributor Author

CC @jhchen @luin

@cmrd-senya
Copy link
Contributor Author

The PR is updated to be compatible with the recent changes to TypeScript CC @luin

@gbonker
Copy link

gbonker commented Jan 4, 2023

Hi! Just wanted to bump this. Assuming this pull request accurately adds and toggles the aria-pressed attribute on the editor's buttons as it states (which it looks to me like it does), I'd like to advocate that this pull request be reviewed and merged as soon as possible. At my company, we have been working through an accessibility audit for the past couple years, where this lack of an aria-pressed attribute was flagged. Rather than needing to build our own custom solution, it would be great if we could simply update Quill on our end to a more accessible version so that the hundreds of thousands of both our customers and internal employees could benefit from this. Is there anything blocking this pull request from moving forward?

@lindacodes
Copy link

Bumping this too. I also work in accessibility and getting this merged would solve a lot of headaches for developers and would improve the user experience for those dependent on assistive technology. I’m happy to help with testing if that’s what’s holding this up?

@luin luin merged commit 7810032 into slab:develop Aug 7, 2023
5 checks passed
@luin
Copy link
Member

luin commented Aug 7, 2023

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants