Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selection-change not firing on DOM mutations #3591

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Fix selection-change not firing on DOM mutations #3591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions core/selection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class Selection {
const native = this.getNativeRange();
if (native == null) return;
if (native.start.node === this.cursor.textNode) return; // cursor.restore() will handle
this.emitter.once(Emitter.events.SCROLL_UPDATE, () => {
this.emitter.once(Emitter.events.SCROLL_UPDATE, (source, mutations) => {
try {
if (
this.root.contains(native.start.node) &&
Expand All @@ -50,7 +50,13 @@ class Selection {
native.end.offset,
);
}
this.update(Emitter.sources.SILENT);
const triggeredByTyping = mutations.some(
mutation =>
mutation.type === 'characterData' ||
mutation.type === 'childList' ||
(mutation.type === 'attributes' && mutation.target === this.root),
);
this.update(triggeredByTyping ? Emitter.sources.SILENT : source);
} catch (ignored) {
// ignore
}
Expand Down