🐛 Fix inserting newlines into formatted text #3582
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider a document with a single piece of bold text. As a
Delta
, thiswould be represented as:
Now consider the following
Delta
being applied:The above
Delta
will:Indeed, using
doc.compose(delta)
yields:However, the same result is not reached when using the Quill
editor.applyDelta()
, which instead results in bold formatting beingincorrectly applied to our unformatted string:
This happens because Quill does an insert of the whole insertion, but
doesn't handle the line splitting.
This change fixes this issue by splitting ops on newlines, and handling
them separately, which applies the correct formatting.