Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deactivation of image toolbar button after deletion. #316

Merged
merged 1 commit into from
Mar 26, 2015

Conversation

willrowe
Copy link
Contributor

This fixes an issue where the image toolbar button does not update properly after an image has been deleted. In order to reproduce do the following:

  1. Go to the Quill homepage
  2. In the example editor select the image with your cursor (you will see the image button in the toolbar turn blue).
  3. Click the image button in the toolbar.
    At this point you will see that the image has been removed, but the button is still blue, seeming to indicate there is an image still present. If you select somewhere else or use the left/right keys and then come back to that same position it will be properly stay deactivated.
    There were no tests for the image tooltip module unfortunately, but I based the code on the link tooltip which is somewhat similar.

jhchen added a commit that referenced this pull request Mar 26, 2015
Fix deactivation of image toolbar button after deletion.
@jhchen jhchen merged commit 3d7f95c into slab:develop Mar 26, 2015
@jhchen
Copy link
Member

jhchen commented Mar 26, 2015

Thanks for the PR!

@willrowe willrowe deleted the fix-post-delete-image branch March 26, 2015 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants