Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should deleting a link with Ctrl-K result to text-change 'user' instead of 'api'? #4177

Closed
ile opened this issue May 6, 2024 · 1 comment · Fixed by #4200
Closed

Should deleting a link with Ctrl-K result to text-change 'user' instead of 'api'? #4177

ile opened this issue May 6, 2024 · 1 comment · Fixed by #4200
Assignees
@luin
Labels
bug:functionality

Comments

@ile
Copy link

ile commented May 6, 2024 •
edited
Loading

Steps for Reproduction

If there is a link in the content of a Quill editor, and I select it and press Ctrl-K, the link disappears.

This will result a text-change event with the source of api.

Deleting a link with the tooltip trashcan icon will result a similar event with the source of user.

Maybe there is an inconsistency here?
@ile ile changed the title Should deleting a link with Ctrl-K result to text-change 'api' instead of 'user'? Should deleting a link with Ctrl-K result to text-change 'user' instead of 'api'? May 6, 2024
@luin
Copy link
Member

luin commented May 7, 2024

Yeah I think it should be user

@luin luin self-assigned this May 11, 2024
luin added a commit that referenced this issue May 13, 2024
@luin
Fix event source when deleting a link with shortcuts
6fbbc13 
Closes #4177
@luin luin mentioned this issue May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luin luin

Labels
bug:functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix event source when deleting a link with shortcuts slab/quill
2 participants
@ile @luin