-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolbar elements not accessible to screen readers #3320
Comments
I can work on this, having the same issue using this editor at work and seems like a simple fix. |
It looks like for the buttons you might just need to add the For those looking for a temporary workaround, it may be possible to make a custom toolbar that included the aria-labels. See: https://quilljs.com/docs/modules/toolbar/ |
@jobara unfortunately the temporary workaround does not work, check out this code sandbox using a screenreader. It looks like quill just looks for matching |
@clairefields15 Any updates on this issue? I'm using v1.3.7, and the only part of the toolbar that reads with a screen reader is the option to set a heading level. Everything else still reads as blank buttons. |
You can make your own toolbar html and add aria label. But it will be good to have a native implementation of basic accessibility. |
Thanks for the tip |
Quill 2.0 has been released (announcement post) with many changes and fixes. If this is still an issue please create a new issue after reviewing our updated Contributing guide 🙏 |
Any app that uses Quill will fail accessibility checks (such as the axe browser extension) due to the toolbar not being accessible to screen readers. This is a critical accessibility issue.
The issues Axe finds are:
Providing a minimal, complete and verifiable example will further increase your chances that someone can help.
Steps for Reproduction
Expected behavior:
All toolbar dropdowns and buttons should have
aria-label
attributes, which would allow them to be discernible to screen readers.Actual behavior:
Currently, an element (such as a dropdown or picker) with
.ql-picker-label
have anaria-controls
attribute, but noaria-label
. They also have notitle
attribute, or other text that is visible to screen readers. All other buttons within the toolbar lackaria-label
ortitle
attributes as well.Platforms:
Version:
The text was updated successfully, but these errors were encountered: