Allow ref for insertBefore to be null

slab · Apr 4, 2024 · 20f02f5 · 20f02f5
1 parent 6b48eca
commit 20f02f5
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 - Fix overload declarations for `quill.formatText()` and other methods
 - Expose Bounds type for getBounds()
 - Expose Range type
+- Allow ref for insertBefore to be null
 
 # 2.0.0-rc.4
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/quill/package.json b/packages/quill/package.json
@@ -9,7 +9,7 @@
   "dependencies": {
     "eventemitter3": "^5.0.1",
     "lodash-es": "^4.17.21",
-    "parchment": "3.0.0-rc.0",
+    "parchment": "3.0.0-rc.1",
     "quill-delta": "^5.1.0"
   },
   "devDependencies": {

diff --git a/packages/quill/src/blots/block.ts b/packages/quill/src/blots/block.ts
@@ -90,7 +90,6 @@ class Block extends BlockBlot {
   }
 
   moveChildren(target: Parent, ref?: Blot | null) {
-    // @ts-expect-error Parchment types are wrong
     super.moveChildren(target, ref);
     this.cache = {};
   }
@@ -116,7 +115,6 @@ class Block extends BlockBlot {
         this.parent.insertBefore(clone, this);
         return this;
       }
-      // @ts-expect-error Fix me later
       this.parent.insertBefore(clone, this.next);
       return clone;
     }
@@ -172,11 +170,9 @@ class BlockEmbed extends EmbedBlot {
     });
     const ref = this.split(index);
     blocks.forEach((block) => {
-      // @ts-expect-error Fix me later
       this.parent.insertBefore(block, ref);
     });
     if (text) {
-      // @ts-expect-error Fix me later
       this.parent.insertBefore(this.scroll.create('text', text), ref);
     }
   }

diff --git a/packages/quill/src/blots/embed.ts b/packages/quill/src/blots/embed.ts
@@ -65,7 +65,6 @@ class Embed extends EmbedBlot {
         };
       } else {
         textNode = document.createTextNode(text);
-        // @ts-expect-error Fix me later
         this.parent.insertBefore(this.scroll.create(textNode), this.next);
         range = {
           startNode: textNode,

diff --git a/packages/quill/src/blots/scroll.ts b/packages/quill/src/blots/scroll.ts
@@ -124,7 +124,7 @@ class Scroll extends ScrollBlot {
     this.optimize();
   }
 
-  insertBefore(blot: Blot, ref?: Blot) {
+  insertBefore(blot: Blot, ref?: Blot | null) {
     if (blot.statics.scope === Scope.INLINE_BLOT) {
       const wrapper = this.scroll.create(
         this.statics.defaultChild.blotName,

diff --git a/packages/quill/src/core/selection.ts b/packages/quill/src/core/selection.ts
@@ -162,7 +162,6 @@ class Selection {
       // TODO Give blot ability to not split
       if (blot instanceof LeafBlot) {
         const after = blot.split(nativeRange.start.offset);
-        // @ts-expect-error Fix me later
         blot.parent.insertBefore(this.cursor, after);
       } else {
         // @ts-expect-error TODO: nativeRange.start.node doesn't seem to match function signature