-
-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added minimumDate and maximumDate to contructor of ActionSheetDatePicker #98
Conversation
@@ -48,23 +48,27 @@ typedef void(^ActionDateCancelBlock)(ActionSheetDatePicker *picker); | |||
@property (nonatomic, copy) ActionDateDoneBlock onActionSheetDone; | |||
@property (nonatomic, copy) ActionDateCancelBlock onActionSheetCancel; | |||
|
|||
+ (id)showPickerWithTitle:(NSString *)title datePickerMode:(UIDatePickerMode)datePickerMode selectedDate:(NSDate *)selectedDate target:(id)target action:(SEL)action origin:(id)origin; | |||
+ (id)showPickerWithTitle:(NSString *)title datePickerMode:(UIDatePickerMode)datePickerMode selectedDate:(NSDate *)selectedDate minimumDate:(NSDate *)minimumDate maximumDate:(NSDate *)maximumDate target:(id)target action:(SEL)action origin:(id)origin; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due backward compatibility - you should create another method with new parameters.
You're right. I've duplicated the constructors. |
@@ -129,7 +181,7 @@ - (void)notifyTarget:(id)target didSucceedWithAction:(SEL)action origin:(id)orig | |||
self.onActionSheetDone(self, @(((UIDatePicker *)self.pickerView).countDownDuration), origin); | |||
else | |||
self.onActionSheetDone(self, self.selectedDate, origin); | |||
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please, avoid of using trailing spaces
Yes, much better. I will review your code in detail soon. Thanks. |
Thanx Petr. I really appreciate your work. 2014-11-17 22:26 GMT+01:00 Petr Korolev [email protected]:
[image: Block21] |
Added minimumDate and maximumDate to constructor of ActionSheetDatePicker.
Updated examples.