Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added minimumDate and maximumDate to contructor of ActionSheetDatePicker #98

Merged
merged 2 commits into from
Dec 3, 2014

Conversation

emmanuelay
Copy link

Added minimumDate and maximumDate to constructor of ActionSheetDatePicker.
Updated examples.

@@ -48,23 +48,27 @@ typedef void(^ActionDateCancelBlock)(ActionSheetDatePicker *picker);
@property (nonatomic, copy) ActionDateDoneBlock onActionSheetDone;
@property (nonatomic, copy) ActionDateCancelBlock onActionSheetCancel;

+ (id)showPickerWithTitle:(NSString *)title datePickerMode:(UIDatePickerMode)datePickerMode selectedDate:(NSDate *)selectedDate target:(id)target action:(SEL)action origin:(id)origin;
+ (id)showPickerWithTitle:(NSString *)title datePickerMode:(UIDatePickerMode)datePickerMode selectedDate:(NSDate *)selectedDate minimumDate:(NSDate *)minimumDate maximumDate:(NSDate *)maximumDate target:(id)target action:(SEL)action origin:(id)origin;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due backward compatibility - you should create another method with new parameters.

@emmanuelay
Copy link
Author

You're right. I've duplicated the constructors.

@@ -129,7 +181,7 @@ - (void)notifyTarget:(id)target didSucceedWithAction:(SEL)action origin:(id)orig
self.onActionSheetDone(self, @(((UIDatePicker *)self.pickerView).countDownDuration), origin);
else
self.onActionSheetDone(self, self.selectedDate, origin);

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, avoid of using trailing spaces

@skywinder
Copy link
Owner

Yes, much better. I will review your code in detail soon. Thanks.

@emmanuelay
Copy link
Author

Thanx Petr. I really appreciate your work.
// Emmanuel

2014-11-17 22:26 GMT+01:00 Petr Korolev [email protected]:

Yes, much better. I will review your code in detail soon. Thanks.


Reply to this email directly or view it on GitHub
#98 (comment)
.

[image: Block21]
EMMANUEL AY
Founder & Lead Developer
Phone: +46-(0)-73-663 50 77
www http://www.block21.com/?source=easignature | twitter
http://twitter.com/emmanuelay | facebook
https://www.facebook.com/emmanuel.ay | linked in
http://www.linkedin.com/profile/view?id=7128269

skywinder added a commit that referenced this pull request Dec 2, 2014
@skywinder skywinder merged commit 0b4f561 into skywinder:master Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants