Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further support for countdown timer #74

Merged
merged 1 commit into from
Oct 15, 2014
Merged

Further support for countdown timer #74

merged 1 commit into from
Oct 15, 2014

Conversation

mgmart
Copy link

@mgmart mgmart commented Oct 11, 2014

These changes should fix #72

Added an additional initialiser which allows to set the countdown timer
to an initial countdown interval.

Changed picker view configuration regarding the existence of countdown
timer.

These changes should fix #72

Added an additional initialiser which allows to set the countdown timer
to an initial countdown interval.

Changed picker view configuration regarding the existence of countdown
timer.
@skywinder
Copy link
Owner

Thanks! I'll review it soon!

@skywinder skywinder force-pushed the master branch 4 times, most recently from 51dfcd5 to 2416593 Compare October 13, 2014 13:02
@skywinder
Copy link
Owner

Thanks.
I decide to not add additional init method because I found, that it can cause potential bugs in this realisation.
It's better to use common init methods, and set countdownDuration parameter the same way (like minimumDate, maximumDate, etc.)

Also, I add this improvements:

  • Update example with CountDownUsage and add Swift examples for all type of DatePickers
  • Update property name according oiginal name of this property
  • Remove unused init function.
  • Add CountDownTimer support to blocks.
  • Remove redundant countDownDuration init

skywinder added a commit that referenced this pull request Oct 15, 2014
- Remove unused init function.
- Add CountDownTimer support to blocks.
- Remove redudant countDownDuration init
@skywinder skywinder merged commit c7a951c into skywinder:master Oct 15, 2014
skywinder added a commit that referenced this pull request Oct 15, 2014
@mgmart
Copy link
Author

mgmart commented Oct 15, 2014

Thank you.
You're right about the initializer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants