Toolbar buttons don't appear when Actionsheet is fired from an iPad Form Sheet or Page Sheet

[LeoSnek]

I have a Form Sheet with a button, when I press it the actionsheet toolbar buttons aren't visible although they do still respond to being pressed.

Here's the actionsheet:

This also happens with a page sheet but not full screen.

This didn't occur with the previous version I was using.

[skywinder]

Yes, very strange bug. I'l handle it.
What is "Form Sheet" and "Page Sheet"?
Can you provide more details to reproduce it:
What kind of Picker?
Which version of iOS?
Can you upload full sreenshot?
Some examples of code to reproduce?

[LeoSnek]

Form Sheet you can see here: http://www.nanaimostudio.com/blog/2010/6/30/modal-form-sheet-navigation-controller.html

Page Sheet: https://cdn.tutsplus.com/mobile/uploads/legacy/iOS-SDK_MFMailComposeViewController/MFMailComposeViewController_iPadMailInterface.png

I'm using an ActionSheetStringPicker, nothing special. My calling code hasn't changed in over a year and works in all scenarios apart from if my button is inside either of the two views mentioned.

I'm running 7.1.2.

Can't provide any more right now.

[jnpdx]

This bug also occurs in v1.1.3 with the iOS 8 beta

[skywinder]

I not reproduce this bug yet.
Recently I apply fix for sizes ( #25 ) I suppose, it could resolve this issue too. Can you check, Is it reproduced on 1.1.4 ?

[jnpdx]

Confirmed -- still happens on 1.1.4

Note that the buttons only fail to appear the first time the picker is displayed -- buttons are there subsequent times

[skywinder]

Ok, so, let's go deeper!
@jnpdx can you provide some code example to reproduce it?

[jnpdx]

Create a single view iPad application and this should do it in ViewController.h

#import "ViewController.h"
#import "ActionSheetStringPicker.h"

@interface ViewController ()

@end

@implementation ViewController

- (void)viewDidLoad {
    [super viewDidLoad];
    // Do any additional setup after loading the view, typically from a nib.


    UIButton *b = [UIButton buttonWithType:UIButtonTypeSystem];
    b.frame = CGRectMake(0, 0, 100, 100);
    [b setTitle:@"Test" forState:UIControlStateNormal];
    [self.view addSubview:b];

    [b addTarget:self action:@selector(buttonPressed:) forControlEvents:UIControlEventTouchUpInside];
}

- (void) buttonPressed:(id)sender {
    NSLog(@"Test");

    UIViewController *x = [[UIViewController alloc] init];
    x.modalPresentationStyle = UIModalPresentationFormSheet;

    [self showViewController:x sender:self];
    x.view.backgroundColor = [UIColor whiteColor];

    UIButton *b = [UIButton buttonWithType:UIButtonTypeSystem];
    b.frame = CGRectMake(0, 0, 100, 100);
    [b setTitle:@"Picker" forState:UIControlStateNormal];
    [x.view addSubview:b];

    [b addTarget:self action:@selector(pickerButtonPressed:) forControlEvents:UIControlEventTouchUpInside];
}

- (void) pickerButtonPressed:(id)sender {
    NSLog(@"Picker");

    [ActionSheetStringPicker showPickerWithTitle:@"Title"  rows:@[@"Row1",@"Row2",@"Row3"] initialSelection:0  doneBlock:nil cancelBlock:nil origin: (UIView*)sender ];
}

@end

[skywinder]

@jnpdx you forgot specify implementation for [self showViewController: sender:]
Ok, I replaced it with
[self presentViewController:x animated:YES completion:nil];
And know I get the same issue. Ok, try to research it soon! Thanks.

[skywinder]

It very strange bug. Because everything works as expected, all buttons created, but the are not visible! You can also try to click on it, and they clicked!
Ok. I create workaround for it. Thanks for notice. Now it should work.
Check version 1.1.5

You can test it in example project. I create additional modal Popover button for it.

[LeoSnek]

Yep this worked, thanks!

Can I ask what you changed please?

[skywinder]

@staz1000 you can look at lines https://github.com/skywinder/ActionSheetPicker-3.0/blob/540333b4d887df7750a01678303708df5ce8252d/Pickers/AbstractActionSheetPicker.m#L110-115 in commit 540333b

[jnpdx]

Thanks for the fix! Should the button title strings be localized?

[skywinder]

@jnpdx Very properly remark, since it not a system button now. Yes, it should.
But unfortunately I do not have time to do it.

[skywinder]

@jnpdx Thanks to you, I have found that cause this error.

ActionSheetPicker-3.0/Pickers/AbstractActionSheetPicker.m

Line 337 in 540333b

[toolBarItemlabel setTextColor:(NSFoundationVersionNumber > NSFoundationVersionNumber_iOS_6_1) ? [UIColor blackColor] : [UIColor whiteColor]];

Since 1.1.7 buttons will localized again! 🉑

[jnpdx]

Nice!