Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2216

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

BartPortugalec
Copy link

@BartPortugalec BartPortugalec commented Nov 13, 2024

Without vcpkg


Important

Add handling for bash attacks in TES5DamageFormula.cpp by modifying damage calculation logic.

  • Behavior:
    • Modify IsUnarmedAttack to take bool isBashAttack and return false for bash attacks.
    • Modify DetermineDamageFromSource to take bool isBashAttack and use it in IsUnarmedAttack.
    • In CalculateDamage, reduce damage by 70% if hitData.isBashAttack is true.
  • Functions:
    • Update IsUnarmedAttack and DetermineDamageFromSource signatures to include bool isBashAttack.
    • Update CalculateDamage to pass hitData.isBashAttack to DetermineDamageFromSource.

This description was created by Ellipsis for e65700f. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e65700f in 11 seconds

More details
  • Looked at 57 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skymp5-server/cpp/server_guest_lib/formulas/TES5DamageFormula.cpp:13
  • Draft comment:
    Simplify the ternary operation for better readability.
  return !isBashAttack && sourceFormId == 0x1f4;
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The function IsUnarmedAttack has a ternary operation that can be simplified for readability.

Workflow ID: wflow_Fec3JyX5dECQ35BP


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants