Skip to content

Conversation

@zpoint
Copy link
Collaborator

@zpoint zpoint commented Nov 3, 2025

See nightly failure: https://buildkite.com/skypilot-1/smoke-tests/builds/5159#019a4935-765b-46ea-ab3a-16ca97e2dbca

The first deletion timeout, causing the second and third attemp fail.

Robust the scripts:

  1. Longer delete timeout(50 min -> 90 min)
  2. In the beginning of test, delete the cluster if it exist.

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@zpoint
Copy link
Collaborator Author

zpoint commented Nov 3, 2025

/smoke-test -k test_helm_deploy_eks --aws --helm-version 1.0.0.dev20251103 --helm-package skypilot-nightly

@zpoint zpoint requested a review from aylei November 3, 2025 15:50
@kevinmingtarja
Copy link
Collaborator

/smoke-test -k test_helm_deploy_eks --aws --helm-version 1.0.0.dev20251103 --helm-package skypilot-nightly

@zpoint zpoint requested a review from kevinmingtarja November 4, 2025 01:30
Copy link
Collaborator

@kevinmingtarja kevinmingtarja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zpoint !

@zpoint zpoint merged commit e3c9ff1 into skypilot-org:master Nov 4, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants