[Helm chart] Adding support for multi hosts and backends #7832
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for multiple hosts in the Helm ingress template (
templates/ingress.yaml), allowing SkyPilot to route traffic for several backend services (e.g. SkyPilot API, MLflow, Grafana) through a shared HTTPS Load Balancer and common TLS certificate.🔧 Implementation details
Updated
templates/ingress.yamlto replace the singleingress.hostkey with a newingress.hostslist.Introduced nested loops to iterate over multiple hosts and paths:
Retained the original single-host logic (commented out at the end of the file) to show backward compatibility.
No logic was modified outside of
templates/ingress.yaml.🧾 Example rendered ingress
🧩 Values example (to document in
values.yaml)This enables multi-service ingress deployments while keeping compatibility with existing single-host setups.
Describe the tests ran
✅ Environment:
mlops-gke-gcp)✅ Scenarios tested:
Checklist
Tested (run the relevant ones):
bash format.sh/smoke-testorpytest tests/test_smoke.py/quicktest-coreorpytest tests/smoke_tests/test_backward_compat.py