Skip to content

Conversation

@ibpark-moreh
Copy link
Contributor

스크린샷 2025-11-03 오후 3 01 39

This PR adds a 'Sign out' button to the SkyPilot dashboard.

SkyPilot supports two authentication methods: OAuth2 and HTTP Basic Auth. This PR implements conditional behavior for the sign-out button based on the active authentication method.

  • When OAuth2 is enabled:

    • The 'Sign out' button is displayed on the dashboard.
    • When clicked, it calls the /oauth2/sign_out endpoint provided by oauth2-proxy to securely sign the user out.
  • When HTTP Basic Auth is enabled:

    • The 'Sign out' button is hidden.
    • This is because HTTP Basic Auth credentials are managed directly by the browser, and the web application (dashboard) cannot programmatically clear them to force a sign-out. Hiding the button prevents user confusion.

Tested (run the relevant ones):

  • Code formatting: install pre-commit (auto-check on commit) or bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: /smoke-test (CI) or pytest tests/test_smoke.py (local)
  • Relevant individual tests: /smoke-test -k test_name (CI) or pytest tests/test_smoke.py::test_name (local)
  • Backward compatibility: /quicktest-core (CI) or pytest tests/smoke_tests/test_backward_compat.py (local)

@ibpark-moreh ibpark-moreh marked this pull request as ready for review November 3, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant