add user data to admin policy #7800
Merged
+79
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeungjinYang
force-pushed
the
admin-policy-user
branch
2 times, most recently
from
5e247ab to
58bff93
Compare
SeungjinYang
changed the title
SeungjinYang
force-pushed
the
admin-policy-user
branch
2 times, most recently
from
28ba1a8 to
24622de
Compare
aylei
approved these changes
Nov 3, 2025
Collaborator
aylei
left a comment
aylei
left a comment
There was a problem hiding this comment.
LGTM, thanks @SeungjinYang !
Collaborator
|
/smoke-test |
SeungjinYang
force-pushed
the
admin-policy-user
branch
from
24622de to
e972c4f
Compare
SeungjinYang
force-pushed
the
admin-policy-user
branch
from
e972c4f to
127e83f
Compare
Collaborator
Author
|
/smoke-test https://buildkite.com/skypilot-1/smoke-tests/builds/5191 (passed) |
SeungjinYang
force-pushed
the
admin-policy-user
branch
from
fa84b29 to
bc94778
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server side admin policy can benefit from knowing which user made the request - to handle things such as per-user rate limiting, etc. This PR adds the user info to
UserRequeststruct accessible by admin policy.Tested (run the relevant ones):
bash format.sh/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)