[jobs] allow one jobs controller process to manage many jobs #7051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
/quicktest-core |
Collaborator
Author
|
/smoke-test |
Collaborator
Author
|
/smoke-test --kubernetes |
Collaborator
Author
|
/quicktest-core |
This reverts commit 6f98299. Co-authored-by: Christopher Cooper <[email protected]>
This is a relic of a previous implementation that would claim the job without its schedule_state being moved back to WAITING.
| D: await write(row2) | ||
| E: cursor = await conn.execute(read_row2) | ||
| F: await cursor.fetchall() | ||
| The A -> B -> D -> E -> C time sequence will cause B and D read at the |
Collaborator
Author
There was a problem hiding this comment.
At the moment, this is only used for the jobs controller, so I just wanted to get this working. Thanks for the hint though, I'll add a TODO to add this.
cg505
changed the title
Collaborator
|
/quicktest-core --base-branch v0.9.3 |
SeungjinYang
approved these changes
Sep 9, 2025
cg505
added a commit
to cg505/skypilot
that referenced
this pull request
Sep 10, 2025
After skypilot-org#7051, job launch will call sky.launch on the API server under the hood. In consolidation mode, this means the sky.launch requests running to manage the jobs may block other jobs.launch requests that are still submitting. You will definitely see this if you are trying to launch significantly more jobs than you have long executors.
5 tasks
cg505
added a commit
to cg505/skypilot
that referenced
this pull request
Sep 10, 2025
After skypilot-org#7051, job launch will call sky.launch on the API server under the hood. In consolidation mode, this means the sky.launch requests running to manage the jobs may block other jobs.launch requests that are still submitting. You will definitely see this if you are trying to launch significantly more jobs than you have long executors.
cg505
added a commit
that referenced
this pull request
Sep 16, 2025
…7127) * [jobs] in consolidation mode, use a short executor for jobs.launch After #7051, job launch will call sky.launch on the API server under the hood. In consolidation mode, this means the sky.launch requests running to manage the jobs may block other jobs.launch requests that are still submitting. You will definitely see this if you are trying to launch significantly more jobs than you have long executors. * add comment
cg505
added a commit
to cg505/skypilot
that referenced
this pull request
Oct 6, 2025
Previously, after skypilot-org#7051, we allowed the number of jobs launching/running to scale purely based on the controller resources. After this change, we set maximum values for the number that can run and launch, since there are some bottlenecks (e.g. DB) that will not necessarily scale with the instance resources.
5 tasks
cg505
added a commit
that referenced
this pull request
Oct 7, 2025
* [jobs] limit the max number of jobs that can run/launch Previously, after #7051, we allowed the number of jobs launching/running to scale purely based on the controller resources. After this change, we set maximum values for the number that can run and launch, since there are some bottlenecks (e.g. DB) that will not necessarily scale with the instance resources. * address comments
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff on top of Previous PR (#6459): https://github.com/skypilot-org/skypilot/pull/7051/files/79880fa2862d9c3ddfe5323b2520a66094ce7c5d..70f58e11cc2ad5d2bb743466600693e55092f478#diff-53a58c3336a3ceca1c6dbdeb15d780a4c28a00efd0cc9af79096e4e6b79385de
Tested (run the relevant ones):
bash format.shtests/smoke_tests/backward_compat/test_backward_compat.py::TestBackwardCompatibility::test_managed_jobs- with both current and base branches AFTER this PR (test the upgrade path after this PR for future versions)/smoke-test(CI) orpytest tests/test_smoke.py(local)/smoke-test -k test_name(CI) orpytest tests/test_smoke.py::test_name(local)/quicktest-core(CI) orpytest tests/smoke_tests/test_backward_compat.py(local)