-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mount cached mode #4369
Draft
landscapepainter
wants to merge
55
commits into
skypilot-org:master
Choose a base branch
from
landscapepainter:mount_cached_mode
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Mount cached mode #4369
landscapepainter
wants to merge
55
commits into
skypilot-org:master
from
landscapepainter:mount_cached_mode
+408
−187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix permissions * fix permissions
* Add serve for gemma and fix mixtral dependency * Add hf token * fix model len * Add comment * Serve your private gemma * fix serve yaml * readme * Remove chat completion due to the wrong template * add readme * Update llm/gemma/README.md Co-authored-by: Zongheng Yang <[email protected]> * address comments * Update README.md Co-authored-by: Zongheng Yang <[email protected]> * Update llm/gemma/README.md Co-authored-by: Zongheng Yang <[email protected]> * Update llm/gemma/README.md Co-authored-by: Zongheng Yang <[email protected]> * Update llm/gemma/README.md Co-authored-by: Zongheng Yang <[email protected]> * Change to it * Add chat API * use HF_TOKEN env * typo --------- Co-authored-by: Zongheng Yang <[email protected]>
* when removing cudo credential, sky check fails * remove tips * minor hint fix * fix cluster version for k8s * fix typo
…org#3218) * Add retry for docker pull due to daemon not ready * longer wait time * longer wait time * retry earlier * add retry for retries as well * longer wait time * change wait time * format * Add comment * Fix * Fix indent for azure docker config * Fix docker login config * Fix comments * More robust docker login config * Add retry for docker check * minor fix * Add additional test for stop and start with docker * Fix cancelled
…o hriday/unsloth # Conflicts: # README.md # docs/source/index.rst
This is great, thanks @landscapepainter! I noticed this is only S3/GCS. Do we plan to support Azure as well in this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested (run the relevant ones):
bash format.sh
sky stop
andsky start
:pytest tests/test_smoke.py::test_aws_storage_mounts_with_stop --aws
pytest tests/test_smoke.py::test_gcp_storage_mounts_with_stop --gcp
sky stop
andsky start
withcomp_test.yaml
to see if all theMOUNT_CACHED
remains storage remains mounted.comp_test.yaml
:launch
tests:spot
jobs tests:launch
on docker containers:comp_test.yaml
:MOUNT_CACHED
mode can recover from preemption to continue training using our vicuna training script.MOUNT_CACHED
mode performs as much as or better than ourMOUNT
mode when writting checkpoints