-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hourly price and instance type to env SKYPILOT_CLUSTER_INFO #4326
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding these new info @tylerweitzman! LGTM.
A future TODO: add these new information into our docs: https://skypilot.readthedocs.io/en/latest/running-jobs/environment-variables.html#environment-variables-for-run
Could you help run format.sh
in the root folder of the repo to get our CI passed?
@@ -203,7 +203,7 @@ def get_cluster_info( | |||
instances[instance_id] = [ | |||
common.InstanceInfo( | |||
instance_id=instance_id, | |||
internal_ip=instance_info['private_ip'], | |||
internal_ip=instance_info.get('private_ip', instance_info.get('ip')), # Fallback to public IP if private not available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
internal_ip=instance_info.get('private_ip', instance_info.get('ip')), # Fallback to public IP if private not available | |
# Fallback to public IP if private not available | |
internal_ip=instance_info.get('private_ip', instance_info.get('ip')), |
This may fix the linting/formating issue : )
Adds the following KV to the SKYPILOT_CLUSTER_INFO json dump
Ran an existing workflow with it to see the values successfully added