New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core][Docker] Support docker login on RunPod. #4287

Draft

cblmemo wants to merge 1 commit into master from runpod-docker-login

Collaborator

cblmemo commented Nov 7, 2024

Fixes #4269.

TODO: Testing, cleanup after cluster termination.

Tested (run the relevant ones):

Code formatting: bash format.sh
Any manual or new tests for this PR (please specify below)
All smoke tests: pytest tests/test_smoke.py
Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh


          [Core][Docker] Support docker login on RunPod.

421ec56

Collaborator Author

cblmemo commented Nov 8, 2024

Maybe they are including the server name in the image name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet