Linting updates #4259
Draft
Linting updates #4259
+143
−87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andylizf
force-pushed
the
linting-updates
branch
2 times, most recently
from
a6939b4
to
e77ea0e
Compare
andylizf
force-pushed
the
linting-updates
branch
from
e77ea0e
to
70b1f41
Compare
Michaelvll
reviewed
Nov 5, 2024
Comment on lines
-439
to
-441
| string-quote=single | ||
| triple-quote=double | ||
| docstring-quote=double |
There was a problem hiding this comment.
We want to keep these behaviors : )
There was a problem hiding this comment.
@Michaelvll Use Pylint with this configuration instead of pylint-quotes should work well for most cases in the existing repo:
[tool.pylint]
check-quote-consistency = true
load-plugins = ["pylint.extensions.docstyle"]The pylint-quotes is deprecated due to no updates in 3 years and incompatibility with pylint >= 3.0.
|
The PR gets the pre-commit configuration from the current linting/mypy setup. If we decide to proceed with this PR, I will update the corresponding pre-commit configuration. Left comment for visibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh