Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action #4

Open
gr2m opened this issue Oct 22, 2020 · 5 comments
Open

GitHub Action #4

gr2m opened this issue Oct 22, 2020 · 5 comments

Comments

@gr2m
Copy link
Collaborator

gr2m commented Oct 22, 2020

I'm working on creating an official GitHub Action to integrate Skypack's package-score into your CI.

Update

An action exists now:
https://github.com/gr2m/skypack-quality-score-action#readme

But we will likely move the repository to the @skypackjs org, see #4 (comment)

The plan™️

Sample workflow file

name: Skypack Package Score
on:
  push:
    branches:
      - main
  pull_request:
    types:
      - opened
      - synchronize

jobs:
  packageScore:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: skypackjs/package-check@v1

In the first version the Action would just succeed / fail similar to what the binary does. In future we could create a separate check run with a human-friendy report

@stramel
Copy link

stramel commented Oct 22, 2020

@gr2m
Copy link
Collaborator Author

gr2m commented Oct 22, 2020

Yes you could to the same workflow as above, just exchange uses: skypackjs/package-check@v1 with npx @skypack/package-check. But with an action we have more possibilities than a simple success / fail status

@gr2m
Copy link
Collaborator Author

gr2m commented Oct 23, 2020

Here is a first version: could someone give it a try?

https://github.com/gr2m/skypack-quality-score-action

I gotta run now, but will check back later tonight

@gr2m
Copy link
Collaborator Author

gr2m commented Oct 26, 2020

Works as expected:

image

@FredKSchott I would suggest to create a separate repository for the action: https://github.com/skypackjs/package-check-action. Once we rename the repository, I'd publish it to the marketplace so folks can find it. Once that's done, we can discuss adding more features to it, like a better report by creating a check run instead of relying on the binary status of the GitHub Action run

@gr2m gr2m changed the title 🔜 GitHub Action GitHub Action Oct 26, 2020
@FredKSchott
Copy link
Contributor

Awesome! Repo created, just gave you access: https://github.com/skypackjs/package-check-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants