Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"files" recommended or not? #15

Open
dominique-mueller opened this issue Apr 11, 2021 · 1 comment
Open

"files" recommended or not? #15

dominique-mueller opened this issue Apr 11, 2021 · 1 comment

Comments

@dominique-mueller
Copy link

It's weird, cause

  • the rule says No Unnecessary Files
  • the comment above the rule says Has "files"

The docs link is dead, sadly. The rule itself currently validates that a files property exists. Is that actually correct?
@dominique-mueller dominique-mueller mentioned this issue Apr 11, 2021
Closed
@markvandenbrink
Copy link

Also, why do I need to have a files property when I have a .npmignore file to specify what is included in the package? If this check is important, it should also look for the existence of the ignore file as a substitute for the files property.

markvandenbrink added a commit to markvandenbrink/package-check that referenced this issue May 20, 2021
@markvandenbrink
Improve has files check (fixes skypackjs#15)
400d607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dominique-mueller @markvandenbrink