Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Spotless and wire Cleanthat #1792

Closed

Conversation

blacelle
Copy link

@blacelle blacelle commented Mar 5, 2023

This proposes an upgrade of Spotless, and the integration of Cleanthat (to improve automatically the codebase).

The default configuration integrate SafeAndConsensual mutators.

@skylot
Copy link
Owner

skylot commented Mar 6, 2023

Unfortunately, spotless stop supporting java 8 in version 6.14.0 and jadx still uses java 8 for build. I plan to move to java 11 in future versions, but not decided in which one yet.

Another issue: I don't want integration tests to be changed by cleanthat (but formatting with spotless is fine) and for now I am not sure how to archive this.

So, I can't accept this PR right now, but once above issues are resolved I will try to add cleanthat again because it looks cool! 🙂

@skylot skylot closed this Mar 6, 2023
Repository owner deleted a comment from cheatcodezky Mar 6, 2023
@blacelle
Copy link
Author

blacelle commented Mar 6, 2023

I don't want integration tests to be changed by cleanthat (but formatting with spotless is fine) and for now I am not sure how to archive this.

I updated the PR to achieve this.

Unfortunately, spotless stop supporting java 8 in version 6.14.0 and jadx still uses java 8 for build. I plan to move to java 11 in future versions, but not decided in which one yet.

Fine. Cleanthat is also JDk11+.

So, I can't accept this PR right now, but once above issues are resolved I will try to add cleanthat again because it looks cool! 🙂

Thanks for the positive feedback.

@skylot
Copy link
Owner

skylot commented Mar 6, 2023

I updated the PR to achieve this.

exclude 'jadx-core/src/test/java/jadx/tests/integration/**/*.java'

I mean, I want these files to be formatted by spotless but not changed by cleanthat, because code in these files IS a test, so it shouldn't be changed. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants