Fix find_maxima call in find_minima function #475
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass
epsilon
andnum
parameters fromfind_minima
tofind_maxima
.I'd like to take advantage of this PR to add documentation about these parameters and the
rough_period
attribute set to the function, since they seem very important in the calculation. Personally, I've always failed to really understand what their purpose is. Can you explain these, so I can update the docs?