Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds New Cross Index module #40

Closed
wants to merge 1 commit into from

Conversation

dreamalligator
Copy link
Contributor

For Issue #39.

and a Star's names are now as a dictionary
@tritium21
Copy link

Might want to adjust travis.yml so that it will install unittest2

Copy link
Member

@brandon-rhodes brandon-rhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have good news! I have finally come up with an idiom that I like for supporting star catalogs: using a Pandas dataframe to hold all the thousands or tens of thousands of stars. It provides easy looking and filtering for users, and integrates easily into the Star object.

To update this pull request now that Skyfield knows how star catalogs should work, check out the new routine that loads Hipparcos stars:

def load_dataframe(fobj, compression='gzip'):

Simply adapt this New Cross code to the same pattern and this pull request will be ready to merge. (Or, if it's been too long and you're on to other projects, just let me know and we can mark this as ready for other contributors to jump in and help with.)

Thanks!

@brandon-rhodes brandon-rhodes removed their assignment Sep 4, 2018
@brandon-rhodes
Copy link
Member

Since this has gone so long without activity, I am going to close it for now, but I am open at any time to seeing it re-open and seeing a New Cross Index loading routine added that creates a Pandas dataframe using the patterns in skyfield.hipparcos.load_dataframe(). I think it will be a nice addition to Skyfield.

Thanks again for your interest in Skyfield!

@dreamalligator
Copy link
Contributor Author

yes this has been so long without activity, thanks for closing for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants