1、Make spinner_popup_background supports drawable files #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skydoves
reviewed
Apr 29, 2022
There was a problem hiding this comment.
Hey @wxw-9527,
Overall looks good to me :)
But how do you think about supporting spinner_popup_background_color as well? We can support background color and drawable together and prioritize the background between them.
I think it would be much better if we could support the background color with the prioritization below:
- background drawable
- background color
- nothing
Feel free to leave your thoughts about this, thank you!
|
My English is not very good. I don't know if you understand what I think. |
|
Sorry, I forgot to say thank you. |
|
fixed #82 |
skydoves
approved these changes
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guidelines
Make spinner_popup_background supports drawable files
Types of changes
What types of changes does your code introduce?
Preparing a pull request for review
Ensure your change is properly formatted by running:
$ ./gradlew spotlessApplyPlease correct any failures before requesting a review.