Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1、Added new spinner_popup_max_height attribute and property #102

Merged
merged 2 commits into from
May 5, 2022
Merged

1、Added new spinner_popup_max_height attribute and property #102

merged 2 commits into from
May 5, 2022

Conversation

wxw-9527
Copy link
Contributor

@wxw-9527 wxw-9527 commented May 5, 2022

Added new spinner_popup_max_height attribute and property

@wxw-9527 wxw-9527 requested a review from skydoves as a code owner May 5, 2022 01:46
@skydoves
Copy link
Owner

skydoves commented May 5, 2022

Hey @wxw-9527, overall looks good to me :)
But before merging this, please run the command below:

./gradlew apiDump

Thank you!

@wxw-9527
Copy link
Contributor Author

wxw-9527 commented May 5, 2022

OK, I'm very sorry.

Copy link
Owner

@skydoves skydoves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@skydoves skydoves merged commit d2802a0 into skydoves:main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants