Update imports for v2 compatibility #79
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #77
This resolve the go install issue and honours go package structure correctly now. Essentially when the git versioning moved to v2.X.X we should have introduced /v2 into the module name. There are various ways to package it up when this happens including having all of the V1 code at root and then having a copy go into a v2 subfolder and development continue in there, with the v1 root being for backwards compatibility.
However, I believe we only want one version of the code in our master. As such, this PR moves the module entirely to v2. Thus, go install now works as expected using this:
Indeed you can even use @latest and it will find the current v2.8.0 version:
The previous command will always find v1.5.0 as that is the "latest" version of v1:
Please let me know your thoughts on the above and if we are happy to merge this in.
Possible useful docs -> https://go.dev/blog/v2-go-modules