Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Make sure route53 records are propagated across DNS servers… #64

Merged
merged 1 commit into from
Jul 9, 2020
Merged

[FEATURE] Make sure route53 records are propagated across DNS servers… #64

merged 1 commit into from
Jul 9, 2020

Conversation

dipiazzg
Copy link
Contributor

@dipiazzg dipiazzg commented Jul 9, 2020

… - Prevents negative cache issue

@mikekrasn
Copy link
Contributor

Nice one!

citrocity
citrocity approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@citrocity citrocity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dipiazzg dipiazzg merged commit b9dee3b into master Jul 9, 2020
@dipiazzg dipiazzg deleted the wait-for-propagation-route53-records branch July 9, 2020 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dseeley-sky dseeley-sky dseeley-sky approved these changes

@citrocity citrocity citrocity approved these changes

@antoineserrano antoineserrano Awaiting requested review from antoineserrano

@eolix eolix Awaiting requested review from eolix

@sky-amoncadot sky-amoncadot Awaiting requested review from sky-amoncadot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dipiazzg @mikekrasn @citrocity @dseeley-sky