Inventory refresh for redeploy - fix #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dseeley-sky
commented
May 14, 2020
dseeley-sky
commented
- Some client playbooks will require that the dynamic inventory is accurate during redeploy. Perform a re-acquisition of the inventory when hosts are removed/ added during redeploy. Also refresh (clean) the inventory prior to adding hosts the inventory, because this called multiple times now.
- Tidy up - allow cluster_vars.custom_tagslabels to be absent
- Tidy up - replace deprecated _facts modules with _info
- Tidy up - remove duplicated debug logs
+ Some client playbooks will require that the dynamic inventory is accurate during redeploy. Perform a re-acquisition of the inventory when hosts are removed/ added during redeploy. Also refresh (clean) the inventory prior to adding hosts the inventory, because this called multiple times now. + Tidy up - allow cluster_vars.custom_tagslabels to be absent + Tidy up - replace deprecated _facts modules with _info + Tidy up - remove duplicated debug logs
|
LGTM - any edge cases we would need to test? |
+ Re-acquire the dynamic inventory after removing a host too. + Make the redeploy host list deterministic by sorting it pre-slice (bulletproofing for canary=start/finish).
Tested against all schemes. Worth testing by others |
|
LGTM - tested functional with all redeploy schemes + canary start/finish/none options as well. |
antoineserrano
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.