Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect subnet filtering behaviour #62

Closed
mikekrasn opened this issue Jun 4, 2020 · 0 comments · Fixed by #63
Closed

Incorrect subnet filtering behaviour #62

mikekrasn opened this issue Jun 4, 2020 · 0 comments · Fixed by #63

Comments

@mikekrasn
Copy link
Contributor

The subnet filtering work perfectly if subnet name looks like sub-pvt-mgmt-a
Problems starting when subnet looks like mgmt mgmt-services-a res-persist-mgmt us-west-2 as ansible won't be able to filter exact name mgmt mgmt-services-a.

clusterverse/cluster_hosts/tasks/get_cluster_hosts_target.yml

Line 47 in d544eb7

"tag:Name": "{{ cluster_vars[buildenv].vpc_subnet_name_prefix }}{{item}}"

Possible solution is to alter to "tag:Name": "{{ cluster_vars[buildenv].vpc_subnet_name_prefix }}{{item}}*" - add * in the end.
dseeley-sky added a commit that referenced this issue Jun 5, 2020
@dseeley-sky
Allow subnet names to be longer than just the `vpc_subnet_name_prefix…
6c8810e 
…` + `az` (e.g. `test mysvc-us-west-2a myextrastring`). Fixes #62

Also add `UserKnownHostsFile=/dev/null` to EXAMPLE/ansible.cfg (prevents host key check failures).
dseeley-sky added a commit that referenced this issue Jun 5, 2020
@dseeley-sky
Allow subnet names to be longer than just the `vpc_subnet_name_prefix…
ec05524 
…` + `az` (e.g. `test mysvc-us-west-2a myextrastring`). Also make only a single call to get subnets, improving speed. Fixes #62

Add `UserKnownHostsFile=/dev/null` to EXAMPLE/ansible.cfg (prevents host key check failures).
@dseeley-sky dseeley-sky mentioned this issue Jun 5, 2020
Merged
dseeley-sky added a commit that referenced this issue Jun 5, 2020
@dseeley-sky
Allow subnet names to be longer than just the `vpc_subnet_name_prefix…
167d11d 
…` + `az` (e.g. `test mysvc-us-west-2a myextrastring`). Also make only a single call to get subnets, improving speed. Fixes #62 (#63)

Add `UserKnownHostsFile=/dev/null` to EXAMPLE/ansible.cfg (prevents host key check failures).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow subnet names to be longer than just the `vpc_subnet_name_prefix… sky-uk/clusterverse
1 participant
@mikekrasn