Fix initialization of vector of pivoting information in gelsy!

skumagai · Aug 18, 2014 · a049db7 · a049db7
1 parent 5133c46
commit a049db7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/base/linalg/lapack.jl b/base/linalg/lapack.jl
@@ -765,7 +765,7 @@ for (gelsd, gelsy, elty) in
             newB = [B; zeros($elty, max(0, n - size(B, 1)), size(B, 2))]
             lda = max(1, m)
             ldb = max(1, m, n)
-            jpvt = similar(A, BlasInt, n)
+            jpvt = zeros(BlasInt, n)
             rcond = convert($elty, rcond)
             rnk = Array(BlasInt, 1)
             work = Array($elty, 1)
@@ -855,7 +855,7 @@ for (gelsd, gelsy, elty, relty) in
             newB = [B; zeros($elty, max(0, n - size(B, 1)), size(B, 2))]
             lda = max(1, m)
             ldb = max(1, m, n)
-            jpvt = similar(A, BlasInt, n)
+            jpvt = zeros(BlasInt, n)
             rcond = convert($relty, rcond)
             rnk = Array(BlasInt, 1)
             work = Array($elty, 1)

diff --git a/test/linalg4.jl b/test/linalg4.jl
@@ -331,3 +331,7 @@ for newtype in [Diagonal, Bidiagonal, SymTridiagonal, Triangular, Matrix]
     @test full(convert(newtype, A)) == full(A)
 end
 
+# Issue #7886
+x, r = LAPACK.gelsy!([0 1; 0 2; 0 3.], [2, 4, 6.])
+@test_approx_eq x [0,2]
+@test r == 1