-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
&felipeangelimvieira, yarnabrina [MNT] CI step to test that notebooks run #1621
Conversation
FYI @XinyuWuu, @yarnabrina, any ideas why the GHA cannot see the sh script? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1621 +/- ##
=======================================
Coverage 90.19% 90.19%
=======================================
Files 30 30
Lines 4722 4722
=======================================
Hits 4259 4259
Misses 463 463
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
credits:
suggestio due to @felipeangelimvieira |
oh, still permission denied |
I think you haven't changed file level permission, e.g. with chmod. Do you want me to push a test commit in this branch? |
would be appreciated! Probably a problem with my windows |
6c68ff4
to
40568d1
Compare
I think it's working now, please take a look. All I did is this: cd build_tools
chmod +x run_examples.sh CI failed because of code issue, the permission one is resolved. |
Nice! The test now runs as intended! The failure is genuine and has identical root cause with #1614 |
Co-authored-by: Anirban Ray <[email protected]>
This adds a CI step to run all the tutorial notebooks.
The test passes if all tutorial notebooks run without error, and can be used to test the fixes in #1615