Add the support for chai-should/expect

[benjamin99]

No description provided.

[benjamin99]

Hi,
just trying to add the transformers for chai (should & test) apis. Hope this PR can help the project.

[skovhus]

Hi! Thanks for doing this.

There is already a fairly feature complete codemod for this, AlexJuarez/chai-to-jasmine#1, that we have been talking about integrating (there is an issue for that).

Did you have a look on that one? If not I think it makes sense to do that. Just copy paste the transformer and modify it to match our needs.

Please ensure that you support all chai should methods, if something is not working there should be a warning.

Again, thanks for taking your time doing this. : )

[benjamin99]

Sure I would be more than willing to do that.
Would it be okey for you @AlexJuarez ?

[skovhus]

Seems so AlexJuarez/chai-to-jasmine#1

[AlexJuarez]

If you could cleanup the chai-to-jamine transform @benjamin99 found here https://github.com/AlexJuarez/chai-to-jasmine/blob/master/transforms/chai-to-jasmine.js you could also copy in all of the tests https://github.com/AlexJuarez/chai-to-jasmine/tree/master/transforms/__testfixtures__/chai-to-jasmine.

Or if you want me to do that I could finish up my original PR. again I had stopped because the approaches are fairly different, and I wasn't sure how much @skovhus cared about conforming to the code style.

[skovhus]

As long as we have a good test coverage and it works, I really don't have hard feeling around style. Eslint --fix does most of the work. : )

[AlexJuarez]

@benjamin99 @skovhus I made a PR #43 see if that works for your needs. Thanks

[skovhus]

@benjamin99 thank you for your work here. I'll move the CLI work of this over to https://github.com/skovhus/jest-codemods/tree/AlexJuarez-chai-to-jasmine

Let me know if you would like to contribute to that branch. Maybe some of your tests cases can be moved over.

Thanks!