Skip to content
This repository was archived by the owner on Jul 10, 2023. It is now read-only.

Add contrib section to readme #1114

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Add contrib section to readme #1114

merged 2 commits into from
Apr 17, 2018

Conversation

skmp
Copy link
Owner

@skmp skmp commented Apr 17, 2018

Cover the basics as a first step for #1102

@AbandonedCart
Copy link
Contributor

Might be a little easier to swallow in smaller chunks

For small/one-off fixes a PR from an github fork is alright. For longer term collaboration we prefer to use namespace branches in the form of <username>/<whatever> in the main repo.

Before you work on something major, make sure to check the issue tracker to coordinate with other contributors, and open an issue to get feedback before doing big changes/PRs. It is always polite to check the history of the code you're working on and collaborate with the people that have worked on it. You can introduce yourself in Meet the team.

Everything goes to master via PRs. Test builds are run automatically for both internal and external PRs, and generally should pass unless there's a really good reason for breakage. You might want to check our CLA, which is required to have your changes merged.

If you are looking for somewhere to start, look for issues marked good first issue or help wanted

@skmp
Copy link
Owner Author

skmp commented Apr 17, 2018

Good point. Updated. LTGM?

@AbandonedCart
Copy link
Contributor

https://lgtm.com/

@skmp
Copy link
Owner Author

skmp commented Apr 17, 2018

lol

@skmp skmp merged commit ba11e63 into master Apr 17, 2018
@AbandonedCart
Copy link
Contributor

ltgm

  • learn the game mechanics

Expression used to tell someone that he isn't doing something right, he did a mistake or he just can't understand how to do it.
Like in a game where you can learn the game mechanics and turn them in your favor, sometimes in rl you can exploit something using a tenth of the others' energy.
Example for 'ltgm':

In a subway, your friends are oblitering the ticket. Suddenly you pop out at the other side without using your ticket.

Genna: "OMG Fanu how did you do that?"
Fanu: "Learn the game mechanics, noob."

@skmp
Copy link
Owner Author

skmp commented Apr 19, 2018

What happened to Let This Get Merged? :p

@AbandonedCart
Copy link
Contributor

millennials

@skmp skmp deleted the skmp/readme-contrib-section branch July 12, 2019 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants