Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/#135/expr for pattern value as entity value #138

Merged
merged 3 commits into from
Mar 29, 2022

Conversation

ltbringer
Copy link
Contributor

resolves #135

@codecov-commenter
Copy link

Codecov Report

Merging #138 (451c840) into master (f918961) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #138   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         2095      2097    +2     
=========================================
+ Hits          2095      2097    +2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
dialogy/constants/__init__.py 100.00% <100.00%> (ø)
...ialogy/plugins/text/list_entity_plugin/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f918961...451c840. Read the comment docs.

@ltbringer ltbringer merged commit 9f02165 into master Mar 29, 2022
@ltbringer ltbringer deleted the update/#135/expr-for-pattern-value-as-entity-value branch March 29, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Treat entities with same type and value but dissimilar bodies as different entities?
2 participants