Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow state doesn't clear if any plugin raises exceptions. #136

Closed
ltbringer opened this issue Mar 29, 2022 · 0 comments · Fixed by #137
Closed

Workflow state doesn't clear if any plugin raises exceptions. #136

ltbringer opened this issue Mar 29, 2022 · 0 comments · Fixed by #137
Assignees
@ltbringer
Labels
bug Something isn't working

Comments

@ltbringer
Copy link
Contributor

Describe the bug
Turns seem to have data from previous turns. One exception leaks to all until services are rebooted.

To Reproduce
Steps to reproduce the behavior:

  1. Set workflow with any initial value.
  2. Create an exception in any plugin say return 0/0.
  3. The workflow doesn't clear input or output.

Expected behavior
Even if plugins fail, the workflow must reset. Not doing this currently breaks every turn until the issue is resolved.

Screenshots
Screenshot from 2022-03-29 19-57-12
The entities above are not part of the turn with alternatives here:

Screenshot from 2022-03-29 19-58-05

Desktop (please complete the following information):

  • OS: Any
  • Python version 3.8
@ltbringer ltbringer added the bug Something isn't working label Mar 29, 2022
@ltbringer ltbringer self-assigned this Mar 29, 2022
ltbringer added a commit that referenced this issue Mar 29, 2022
@ltbringer
test: failing test to validate #136
5576f43
ltbringer added a commit that referenced this issue Mar 29, 2022
@ltbringer
test: reproduce #136
8943fb2
ltbringer added a commit that referenced this issue Mar 29, 2022
@ltbringer
fix: #136.
d7bdfd9
@ltbringer ltbringer mentioned this issue Mar 29, 2022
Merged
ltbringer added a commit that referenced this issue Mar 29, 2022
@ltbringer
Fix/#136/clear workflow state on exceptions (#137)
f918961 
* test: failing test to validate #136

* test: reproduce #136

* fix: #136.

* refactor: try .. finally is more succint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ltbringer ltbringer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/#136/clear workflow state on exceptions skit-ai/dialogy
1 participant
@ltbringer