Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slot filler should fill entities without entity declaring slot names #13

Closed
ltbringer opened this issue Apr 13, 2021 · 0 comments
Closed

Slot filler should fill entities without entity declaring slot names #13

ltbringer opened this issue Apr 13, 2021 · 0 comments
Assignees
@ltbringer
Labels
feature

Comments

@ltbringer
Copy link
Contributor

In the current implementation, duckling entities don't come with slot_names defined and once produced by the parser, we are using hacks to get this working.

Since we already pass rules to slot_filler, shouldn't it take care of the entity type and slot name association?
@ltbringer ltbringer self-assigned this Apr 13, 2021
ltbringer added a commit that referenced this issue Apr 13, 2021
@ltbringer
feat: #13
db4d1c0 
Entities no longer need to specify slot_names.
The information is already contained in rules, we modified the filling logic
to not ask the entity, rather use the rules for the relationship.
ltbringer added a commit that referenced this issue Apr 13, 2021
@ltbringer
Merge pull request #16 from Vernacular-ai/feat/#13
ac7333b 
feat: #13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ltbringer ltbringer

Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ltbringer