Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Use body replacement instead of details/summary or HTML comments #11

Merged
merged 8 commits into from
May 30, 2023
Merged

Conversation

heiskr
Copy link
Contributor

@heiskr heiskr commented May 25, 2023

BREAKING CHANGE: Updates format of Skills courses to meet updated accessibility requirements. For more information, see skills/introduction-to-github#408

@heiskr heiskr changed the title BREAKING CHANGE: BREAKING CHANGE: Use body replacement instead of details/summary or HTML comments May 25, 2023
Copy link

@hectorsector hectorsector left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we tested this in the Intro course I think it's safe to OK - although I'm ready to help test against other courses as we're ready to move on.

@heiskr heiskr merged commit c71686c into skills:main May 30, 2023
@sinsukehlab
Copy link
Contributor

This PR has not followed the commit conventions.
The BREAKING CHANGE: token must be in the footer of the commit.
Cf. semantic-release/semantic-release#2283

@heiskr
Copy link
Contributor Author

heiskr commented Jun 1, 2023

Ah, that would explain for the need for making the tags manually :) I'm terrible about commit descriptions 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants