Skip to content
This repository has been archived by the owner on Sep 11, 2019. It is now read-only.

Set with invalid expiry time should not set key #7

Closed
bmerry opened this issue Jan 24, 2018 · 1 comment
Closed

Set with invalid expiry time should not set key #7

bmerry opened this issue Jan 24, 2018 · 1 comment
Assignees
@bmerry

Comments

@bmerry
Copy link

bmerry commented Jan 24, 2018

A call like set('x', 'y', ex=-1) should have no side effects (and does not in real redis), but fakenewsredis 0.9.3 still sets 'x' to 'y' but does not set an expiry time.
@bmerry bmerry self-assigned this Jan 24, 2018
bmerry added a commit that referenced this issue Jan 24, 2018
@bmerry
Fix handling of invalid expiry times
4bd92c7 
This fixes #5 (zero expiry time should be treated as invalid) and #7
(key should not be set when expiry time is invalid).
@bmerry bmerry mentioned this issue Jan 24, 2018
Merged
@bmerry
Copy link
Author

bmerry commented Jan 24, 2018

Closed via #8.

@bmerry bmerry closed this as completed Jan 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bmerry bmerry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bmerry