Fix filtered posts showing during "auto refresh" #255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been experiencing a bug where, after the app is idle for a while, filtered ("hide") posts are appearing in the home timeline. I could not reproduce in debug mode, but it is happening somewhat consistently in the Play Store apk for me.
I guess it is related to empty
wordFilters
list as it's the only difference between manual refresh and auto refresh. Is it possible that we're not callingmaybeUpdateLocalInfo()
?Anyway, I removed the
filters.isEmpty()
validation so status withfiltered
can still be checked. The semantics is the same as the constructorStatusFilterPredicate(String accountID, Filter.FilterContext context)
still checks forwordFilters
.