Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY BUG] Megalodon will always partially sign back in after reinstall, even after logging out and clearing data first #965

Open
Leah96xxx opened this issue Jan 13, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@Leah96xxx
Copy link

Describe the bug

While troubleshooting another issue that I may post about shortly, I discovered that Megalodon will always sign back in to my account when I reinstall it. This occurs regardless of what I do prior to reinstalling it.

I have tried:

  • Log out before uninstalling
  • Log out and clear app data in Android settings before uninstalling
  • Log out, clear data, then restart the phone before uninstalling
  • Log out, clear data, then restart the phone after uninstalling but before reinstalling
    All of the above will not prevent the app from automatically signing back in after being reinstalled.

However, when the app restarts, it gives the error "The access token was revoked" and won't let you post any toots, so I guess that's one good thing. But my point is that a newly reinstalled app shouldn't sign into anything automatically, especially after having its data cleared.

I did also notice that the uninstallation takes a fraction of the time that the install takes. Not sure if this is related.

To reproduce

Steps to reproduce the behavior:

  1. Log out of Megalodon
  2. Clear app data in Android
  3. Uninstall Megalodon
  4. Open the app and be automatically signed in.

Does this happen in the official app?

Does this issue also occur with the respective upstream release?

No (Mastodon Play Store latest)

Screenshots and screen recordings

(Apologies for compression issues. The video was 47MB but GitHub only allows up to 10MB.)

Screen_Recording_20240113_122508_Google.Play.Store.mp4

Version

Megalodon version: 2.1.6+fork.110 (110) (Play Store latest)

Crash log

N/A

@Leah96xxx Leah96xxx added the bug Something isn't working label Jan 13, 2024
@Leah96xxx Leah96xxx changed the title [SECURITY BUG] Megalodon will always sign back in after reinstall, even after logging out and clearing data first [SECURITY BUG] Megalodon will always partially sign back in after reinstall, even after logging out and clearing data first Jan 13, 2024
@PurpleStephyr
Copy link

Also seeing this bug. Worse yet, when I migrated data from one phone to another, I noticed that I was already signed in on Megalodon

@Jeder321
Copy link

From what I understand, this behaviour is from Google saving and restoring app settings, and I have seen it do it even for apps that weren't installed from Google Play. Is it really megalodon "bug"?

@PurpleStephyr
Copy link

From what I understand, this behaviour is from Google saving and restoring app settings, and I have seen it do it even for apps that weren't installed from Google Play. Is it really megalodon "bug"?

Ya, I read something like that here: https://stackoverflow.com/questions/33169618/an-android-app-remembers-its-data-after-uninstall-and-reinstall

It might be desirable to exclude the account data from this backup as the answer suggests by updating the app manifest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants