chore: clippy

rsync-fetcher/src/main.rs

@@ -108,7 +108,7 @@ async fn main() -> Result<()> {
     info!(?stat, "transfer plan stat.");
     progress.set_length(stat.total_bytes);
     let transfer_items = Arc::new(transfer_items);
-    let (_, mut generator, mut receiver, _) = tokio::try_join!(
+    let ((), mut generator, mut receiver, ()) = tokio::try_join!(
         tokio::spawn({
             let transfer_items = transfer_items.clone();
             async move { downloader.tasks(&transfer_items).await }

rsync-fetcher/src/rsync/checksum.rs

@@ -197,6 +197,7 @@ fn checksum_payload_(
 
 #[cfg(test)]
 mod tests {
+    #![allow(clippy::ignored_unit_patterns)]
     use std::io::{Seek, SeekFrom, Write};
 
     use proptest::prop_assert_eq;

rsync-fetcher/src/rsync/envelope.rs

@@ -126,8 +126,7 @@ impl<T: AsyncBufRead + Unpin> AsyncRead for EnvelopeRead<T> {
                         match b4 {
                             7 => (),
                             t => {
-                                let mut errbuf = vec![];
-                                errbuf.resize(self.frame_remaining, 0);
+                                let errbuf = vec![0; self.frame_remaining];
                                 self.pending_error = Some((t, errbuf));
                                 return self.poll_err(ctx, buf);
                             }

rsync-gateway/src/cache.rs

@@ -322,7 +322,7 @@ impl Expiry<Vec<u8>, Arc<MaybeCompressed>> for ExpiryPolicy {
 
 #[cfg(test)]
 mod tests {
-    #![allow(clippy::explicit_deref_methods)]
+    #![allow(clippy::explicit_deref_methods, clippy::ignored_unit_patterns)]
 
     use std::future::ready;
 

rsync-gateway/src/render.rs

@@ -250,7 +250,7 @@ fn req_path_to_root_href(prefix: &str, req_path: &[u8]) -> String {
 
 #[cfg(test)]
 mod tests {
-    #![allow(clippy::explicit_deref_methods)]
+    #![allow(clippy::explicit_deref_methods, clippy::ignored_unit_patterns)]
 
     use std::sync::atomic::{AtomicBool, Ordering};
     use std::time::Duration;

rsync-gateway/src/utils.rs

@@ -72,7 +72,7 @@ impl<T> ArchiveWith<T> for SkipRkyv {
     type Archived = ();
     type Resolver = ();
 
-    unsafe fn resolve_with(_: &T, _: usize, _: Self::Resolver, _: *mut Self::Archived) {
+    unsafe fn resolve_with(_: &T, _: usize, (): Self::Resolver, _: *mut Self::Archived) {
         panic!("Attempted to resolve a field explicitly skipped")
     }
 }

rsync-gc/src/s3.rs

@@ -31,7 +31,7 @@ pub async fn bulk_delete_objs(op: &Operator, opts: &Opts, hashes: &[[u8; 20]]) -
             .iter()
             .map(|hash| format!("{prefix}{:x}", hash.as_hex()))
             .collect();
-        op.remove(keys).map_ok(|_| pb.inc(chunk.len() as u64))
+        op.remove(keys).map_ok(|()| pb.inc(chunk.len() as u64))
     }))
     .buffer_unordered(DELETE_CONN)
     .try_collect::<()>()