Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General codebase cleanup #61

Merged
merged 6 commits into from
Aug 31, 2022
Merged

General codebase cleanup #61

merged 6 commits into from
Aug 31, 2022

Conversation

PhotonQuantum
Copy link
Member

@PhotonQuantum PhotonQuantum commented Aug 31, 2022 •
edited
Loading

There are several modifications done in this PR.

  • Add documents.
  • Clarify the naming of some variables to suit their purpose better.
  • Migrate from slog to tracing so we automatically get structured logging support, which our elastic search backend can easily parse.
  • Refactor artifact download logic to make it more understandable and easier to maintain.

The motivation for this PR is to prepare for the following actix-web migration.

See #60 for more details.

r? @skyzh

This was referenced Aug 31, 2022
Open
Merged
@PhotonQuantum PhotonQuantum merged commit f68ca2d into sjtug:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhotonQuantum @skyzh