Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change python version check #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change python version check #36

wants to merge 2 commits into from

Conversation

natemaia
Copy link

Hello,

I run neovim without python2 support, currently without setting g:gundo_prefer_python3 I get an error regarding the import of the neovim module (to be expected), this removes the need to set the above mentioned variable when running with only python3 support, while otherwise keeping the same default behaviour.

Cheers, and thank you for creating such an awesome plugin.

Nathaniel

Hello,

I run neovim without python2 support, currently without setting `g:gundo_prefer_python3` I get an error regarding the import of the neovim module (to be expected), this removes the need to set the above mentioned variable when running with only python3 support, while otherwise keeping the same default behaviour.

Cheers, and thank you for creating such an awesome plugin.

 Nathaniel
These check are no longer needed, we will either have python, or python3, or have thrown an error and finished.
@unclechu
Copy link

👍 I would prefer Python 3 be selected by default. At some point the plugin stopped working for me on NixOS. It turned out that Python 2 support was dropped:

https://github.com/NixOS/nixpkgs/blob/953909341ea62291a4c4a9483214f9a12d58ec99/pkgs/applications/editors/neovim/wrapper.nix#L50

I was happy to find this MR and this option g:gundo_prefer_python3 to see that I can make the plugin work again. But it would be better to change default behavior.

@natemaia
Copy link
Author

@unclechu I've since switched to https://github.com/mbbill/undotree which is basically the same as gundo but a bit more simple and no conflicting settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants