Repository navigation
fix(flowchart): preserve raw subgraph direction value; normalize TD→TB only for dagre - #2
Merged
sjackson0109 merged 4 commits intoMay 7, 2026
Conversation
…inheritDir Agent-Logs-Url: https://github.com/sjackson0109/mermaid/sessions/6e0b59e7-9b3a-4532-bdc3-7d7893b2c0da Co-authored-by: sjackson0109 <38080190+sjackson0109@users.noreply.github.com>
…e-consumption point Agent-Logs-Url: https://github.com/sjackson0109/mermaid/sessions/ed8547c3-2e55-4088-bbec-113a7976d0aa Co-authored-by: sjackson0109 <38080190+sjackson0109@users.noreply.github.com>
Agent-Logs-Url: https://github.com/sjackson0109/mermaid/sessions/ed8547c3-2e55-4088-bbec-113a7976d0aa Co-authored-by: sjackson0109 <38080190+sjackson0109@users.noreply.github.com>
Agent-Logs-Url: https://github.com/sjackson0109/mermaid/sessions/367892ea-7828-42ac-a114-e4e3119212ef Co-authored-by: sjackson0109 <38080190+sjackson0109@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
sjackson0109
May 7, 2026 18:43
View session
sjackson0109
marked this pull request as ready for review
May 7, 2026 18:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📑 Summary
addSubGraph()was normalizingdirection TDtoTBbefore storing it on the subgraph object. This causedsubgraph.dirto return'TB'instead of the user-authored'TD', breaking the assertion:📏 Design Decisions
addSubGraph(): removed theTD→TBnormalization from the storage path.subGraph.dirnow holds the raw user value (e.g.'TD').getData(): normalization is applied inline when constructing the dagre layout node — dagre still receives the canonical'TB'it requires:TDis a user-facing alias;TBis dagre's internal canonical form. These two concerns now live at the correct layers.📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.