Improve spaced repetition interface #15627
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Vanessa219
reviewed
Sep 8, 2025
app/src/card/newCardTab.ts
Outdated
| }); | ||
| async update() { | ||
| const cardsData = await fetchCardsData(); | ||
| await renderCardsAndBindEvents(this.element, this.data, cardsData); |
There was a problem hiding this comment.
源代码中没有以下代码，但是调用的函数里面有，没有影响么？
editor = await bindCardEvent({
app: options.app,
element: this.element,
id: this.data.id,
title: this.data.title,
cardType: this.data.cardType,
cardsData,
});
customObj.editors.push(editor);
|
可以了，现在不会重复添加事件监听器 |
Vanessa219
reviewed
Sep 8, 2025
| }); | ||
| async update() { | ||
| const cardsData = await fetchCardsData(); | ||
| await renderCardsAndBindEvents(this.element, this.data, cardsData ,undefined, true); |
There was a problem hiding this comment.
不太理解为什么一定要这么重构，可以只改业务么？看上去多了 push
There was a problem hiding this comment.
之前的 update 方法完全是坏的，修复之后重复的代码太多所以又抽象成一个函数了
There was a problem hiding this comment.
renderCardsAndBindEvents 和 fetchCardsData 看上去是一个重构。并且修改了原有代码业务：在原有的 108 行 添加了 customObj.editors.push(editor); 。这个用肉眼看上去并不能修复之前完全坏的 update 方法，可能还会引出更多的问题。
|
可以了，现在会销毁旧的 editor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openTabupdateCards option is null #10331使用新窗口打开的闪卡与当前正在复习的闪卡不一致 #14149 01在新页签中打开选项 #14149 02