Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 改进页签拖拽高亮 #13549

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

🎨 改进页签拖拽高亮 #13549

wants to merge 2 commits into from
+29 −18

Conversation

TCOTC
Copy link
Contributor

@TCOTC TCOTC commented Dec 19, 2024 •
edited
Loading

主要改进两个问题：

  1. 从上方或左侧将页签拖入 protyle 时动画方向的一点问题
  2. 从下方或右侧将页签拖入 protyle 时会出现预期外的滚动条

问题的录屏：

video.webm

然后还把位置判断的部分改了，之前的区域是方形的，现在改成梯形：

bdabc1b1955551b07f596542198a8b16

另外，有的地方我没看懂所以不知道有没有改对

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 19, 2024

另外我还发现一个问题，鼠标移动的速度超过高亮的动画效果之后就会出现异常，但我解决不了：

video.webm

@Vanessa219
Copy link
Member

区域位置目前是比较合理的，可以不用修改。

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 20, 2024

我觉得梯形更合理一点

@Vanessa219
Copy link
Member

如果是梯形的话，上切换到左右就不太方便

Jietu20241221-091353-HD.mp4

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 21, 2024

这个是符合预期的，拖到中间靠左就是向左分屏，拖到中间靠上就是向上分屏。

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 21, 2024

GoLand 也是梯形：

video.webm

@Vanessa219
Copy link
Member

IDEA 这样从上切换到左更方便

Jietu20241223-104318-HD.mp4

@TCOTC
Copy link
Contributor Author

TCOTC commented Dec 24, 2024

仔细看了一下，形状应该是这样，又改了一下：

469a131645a9a7548c24f4f56a597be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TCOTC @Vanessa219